Apply where, order, and limit in the right order in TestDriver#29
Merged
KurtThiemann merged 2 commits intomasterfrom Nov 26, 2025
Merged
Apply where, order, and limit in the right order in TestDriver#29KurtThiemann merged 2 commits intomasterfrom
KurtThiemann merged 2 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the order of operations in the TestDriver's query execution. Previously, the driver would filter results, apply the limit, and then sort - producing incorrect results. The fix ensures results are filtered, sorted, and then limited, matching standard SQL query execution order.
Key Changes:
- Refactored
findEntries()to collect all matching entries before applying order and limit - Moved ordering logic inside
findEntries()to execute before offset/limit application - Added test case to verify correct behavior with ORDER BY and LIMIT
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Driver/Test/TestTable.php | Refactored query execution to apply WHERE filter, ORDER BY sort, then OFFSET/LIMIT in correct sequence |
| test/tests/TestDriverTest.php | Added test case validating that ORDER BY is applied before LIMIT |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JulianVennen
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the TestDriver will go through all entries, add entries that match the WHERE condition to the results until the LIMIT is reached, and then sort the result. This produces incorrect results, since the matching models should be sorted before the limit is applied.
Old behavior:
[0, 1, 2, 3, 4, 5, 6, 7]->SELECT * FROM ... LIMIT 3 ORDER BY num DESC->[2, 1, 0]Correct behavior:
[0, 1, 2, 3, 4, 5, 6, 7]->SELECT * FROM ... LIMIT 3 ORDER BY num DESC->[7, 6, 5]